Add engine_getClientVersionV1 interface + ability to get commit hash #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
7930_start
branch
from
17c7c93
to
11c9f74
Compare
rolfyone
reviewed
Mar 13, 2024
ethereum/spec/src/main/java/tech/pegasys/teku/spec/executionlayer/ExecutionLayerChannel.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Mar 13, 2024
...tructure/version/src/main/java/tech/pegasys/teku/infrastructure/version/VersionProvider.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Mar 13, 2024
| } | ||
|
|
||
| @Test | ||
| void getCommitHashIsEmpty_whenGitCommitIdIsNot40Characters(@TempDir Path tempDir) |
There was a problem hiding this comment.
oh see thats interesting, i didn't realise that was important :)
There was a problem hiding this comment.
actually it's overkill given we have tested the happy case constant, I think returning empty is more confusing, so removed that check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
getClientVersionV1inExecutionEngineClientengineGetClientVersioninExecutionLayerChannelgenerateGitPropertiesto create agit.propertiesfile in runtime/JAR which is used byVersionProviderto be able to retrieve the git commit hash (will be used in future PRs)Fixed Issue(s)
related to #7930
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog