Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fields for EIP-1559 txns #204

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Doc fields for EIP-1559 txns #204

merged 2 commits into from
Sep 6, 2023

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Sep 5, 2023

Add maxPriorityFeePerGas and maxFeePerGas fields to eth_sendTransaction and eth_signTransaction parameter descriptions.

preview: https://doc-web3signer-git-196-eip-1559-infura-web.vercel.app/reference/api/json-rpc#eth_signtransaction

fixes #196

Signed-off-by: Alexandra Tran <[email protected]>
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-web3signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 8:11pm

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

@rajkaramchedu rajkaramchedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

docs/reference/api/json-rpc.md Outdated Show resolved Hide resolved
Signed-off-by: Alexandra Tran <[email protected]>
@alexandratran alexandratran merged commit c5ecef7 into main Sep 6, 2023
7 checks passed
@alexandratran alexandratran deleted the 196-eip-1559 branch September 6, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EIP-1559 transactions
3 participants