Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests to ExecuteWithClient for pipelines cmds #2111

Merged
merged 27 commits into from
Jan 30, 2025
Merged

chore: add tests to ExecuteWithClient for pipelines cmds #2111

merged 27 commits into from
Jan 30, 2025
+1,802 −169

Conversation

raulb
Copy link
Member

@raulb raulb commented Jan 28, 2025 •
edited
Loading

Description

Fixes #2095

  • pipelines ls
  • pipelines describe
  • connectors ls
  • connectors describe
  • processors ls
  • processors describe
  • processorplugins ls
  • processorplugins describe
  • connectorplugins ls
  • connectorplugins describe

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb changed the title chore: add tests to ExecuteWithClient chore: add tests to ExecuteWithClient for pipelines cmds Jan 29, 2025
@raulb raulb marked this pull request as ready for review January 29, 2025 15:52
@raulb raulb requested a review from a team as a code owner January 29, 2025 15:52
@raulb raulb requested a review from maha-hajja January 29, 2025 15:52
maha-hajja
maha-hajja approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/conduit/internal/testutils/mock_helpers.go Outdated Show resolved Hide resolved
hariso
hariso approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Raúl!

cmd/conduit/root/pipelines/describe_test.go Show resolved Hide resolved
cmd/conduit/root/processorplugins/processor_plugins.go Show resolved Hide resolved
@raulb raulb merged commit 9ae2dc5 into main Jan 30, 2025
3 checks passed
@raulb raulb deleted the add-execute-tests branch January 30, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: Improve test coverage
3 participants
@raulb @hariso @maha-hajja