Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump github.com/twmb/franz-go/pkg/sr from 1.1.0 to 1.2.0 #1910

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 15, 2024

Bumps github.com/twmb/franz-go/pkg/sr from 1.1.0 to 1.2.0.

Changelog

Sourced from github.com/twmb/franz-go/pkg/sr's changelog.

v1.2.0

This release contains new formatting features and sets the stage for a new admin administration package to be added in v1.3.0. For now, the kadm package is in a separate unversioned module. The API is relatively stable, but I'd like to play with it some more to figure out what needs changing or not. Any external experimenting and feedback is welcome.

There are two new types introduced in the kgo package: RecordFormatter and RecordReader. Both of these extract and improve logic used in the kcl repo. These are effectively powerful ways to format records into bytes, and read bytes into records. They are not exactly opposites of each other due to reasons mentioned in the docs. I expect formatting to be more useful than reading, and formatting is actually surprisingly fast if the formatter is reused. The one off Record.AppendFormat builds a new formatter on each use and should only be used if needed infrequently, because building the formatter is the slow part.

I am considering removing the default of snappy compression for the v1.3 release. I generally find it useful: many people forget to add compression which increases network costs and makes broker disks fill faster, and snappy compression is cheap cpu-wise and fast. However, some people are confused when their bandwidth metrics look lower than they expect, and snappy does mean throughput is not as high as it could be. Removal of snappy by default may or may not happen, but if anybody agrees or disagrees with it, please mention so in an issue or on discord.

There are a few minor behavior changes in this release that should make default clients safer (lowering max buffered memory) and faster on request failures. These behavior changes should not affect anything. As well, the bench utility no longer uses snappy by default.

Non-formatter/reader/kadm commits worth mentioning:

  • a8dbd2f broker: add context to responses that look like HTTP
  • ec0d81f broker: avoid non-debug logs on ErrClientClosed
  • af4fce4 beahvior change bench: use no compression by default, remove -no-compression flag
  • d368d11 bench: allow custom certs with -ca-cert, -client-cert, -client-key
  • fbf9239 broker: add two new connection types, cxnGroup and cxnSlow
  • 2d6c1a8 behavior change client: lower RequestTimeoutOverhead and RetryTimeout defaults
  • 9bcfc98 kgo: only run req/resp handling goroutines when needed
  • b9b592e behavior change kgo: change default MaxBufferedRecords from unlimited to 10,000
  • 19f4e9b and 58bf74a client: collapse shard errors
  • 126778a client: avoid sharding to partitions with no leader
  • 254764a behavior change kversion: skip WriteTxnMarkers for version guessing

v1.1.4

... (truncated)

Commits
  • bbcd318 CHANGELOG: doc v1.2.0
  • a8dbd2f broker: add context to responses that look like HTTP
  • 1d51332 kadm: add NumReplicas to PartitionDetails
  • c44763e kadm: fix recent breakages
  • c1c864b kadm: add NewOptClient to create client from kgo options
  • 2106580 kadm: add Close method
  • 68f7b1d kadm: sort brokers in metadata response by default
  • 36a40b7 all: update docs
  • 246a796 kadm: add MetadataWithoutTopics
  • 4ee9724 Revert "kmsg: add 60s timeout defaults where where were no defaults"
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/twmb/franz-go/pkg/sr](https://github.com/twmb/franz-go) from 1.1.0 to 1.2.0.
- [Changelog](https://github.com/twmb/franz-go/blob/master/CHANGELOG.md)
- [Commits](twmb/franz-go@v1.1.0...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/twmb/franz-go/pkg/sr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 15, 2024 09:03
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 15, 2024
@github-actions github-actions bot enabled auto-merge (squash) October 15, 2024 09:03
@github-actions github-actions bot merged commit f92354e into main Oct 15, 2024
5 checks passed
@github-actions github-actions bot deleted the dependabot/go_modules/github.com/twmb/franz-go/pkg/sr-1.2.0 branch October 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants