Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update processor SDK, add middleware #1742

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Update processor SDK, add middleware #1742

merged 8 commits into from
Aug 5, 2024

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Aug 2, 2024 •
edited
Loading

Description

This PR includes the following changes:

  • apply processor middleware to builtin processors
  • use config.Config as configuration map type
  • take into account middleware parameters in tests

Depends on ConduitIO/conduit-processor-sdk#68.

Fixes #1707

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon
update processor SDK
9059d94 
- apply processor middleware to builtin processors
- use config.Config for configuration map
- take into account middleware parameters in tests
@lovromazgon lovromazgon requested a review from a team as a code owner August 2, 2024 14:53
@lovromazgon
processor changes
07059ad 
- update processor SDK
- set SchemaService for builtin processors
- add support for "time" in field.convert processor
@lovromazgon
go generate
611a744
raulb
raulb reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovromazgon Looks good. I left a bunch of comments (stopped in some point) to rename the parameter name m to something such as c now that the type was changed in the processor SDK. If you agree with that change, maybe it'd safer to search across the different builtin processors.

pkg/plugin/processor/builtin/impl/avro/decode.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/avro/encode.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/avro/encode.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/base64/encode.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/custom/javascript.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/field/exclude.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/field/rename.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/field/set.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/json/decode.go Outdated Show resolved Hide resolved
pkg/plugin/processor/builtin/impl/json/encode.go Outdated Show resolved Hide resolved
@hariso hariso mentioned this pull request Aug 5, 2024
Merged
4 tasks
@lovromazgon lovromazgon merged commit d6e83ce into main Aug 5, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/processor-middleware branch August 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Schemas] Decode raw data in records with schemas before passing them to processors
2 participants
@lovromazgon @raulb