Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more example pipelines #1447

Merged
merged 10 commits into from
Apr 1, 2024
Merged

Add more example pipelines #1447

merged 10 commits into from
Apr 1, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Mar 19, 2024

Description

Closes #1118.

Note that I didn't add an example of a destination processor, since there's already an example of a source processor.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review March 20, 2024 12:19
@hariso hariso requested a review from a team as a code owner March 20, 2024 12:19
@hariso hariso enabled auto-merge (squash) March 21, 2024 20:50
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariso Looks good. I was thinking that maybe we could incorporate these to our public docs. The only one we've got now there is the one from file to file. At the very least, we could add a callout from docs to these. What do you think?

@hariso
Copy link
Contributor Author

hariso commented Apr 1, 2024

@raulb Good that you remember that one... The file-to-file example on conduit.io mentions the general steps for running a pipeline file, so maybe we can add a link to this directory?

@hariso hariso merged commit db24b6a into main Apr 1, 2024
4 checks passed
@hariso hariso deleted the haris/more-examples branch April 1, 2024 15:38
@raulb
Copy link
Member

raulb commented Apr 1, 2024

@hariso yup. I will also include the ones you added here. Thank you for adding them in the first place. 🥂

raulb added a commit to ConduitIO/conduit-site that referenced this pull request Apr 2, 2024
raulb added a commit to ConduitIO/conduit-site that referenced this pull request Apr 2, 2024
raulb added a commit to ConduitIO/conduit-site that referenced this pull request Apr 2, 2024
* doc: include more examples

Uses ConduitIO/conduit#1447

* fix: address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more example pipelines
2 participants