Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readmegen: show if parameter is required or optional #258

Merged
merged 14 commits into from
Feb 4, 2025
Merged

readmegen: show if parameter is required or optional #258

merged 14 commits into from
Feb 4, 2025

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Feb 3, 2025

Description

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner February 3, 2025 17:56
raulb
raulb reviewed Feb 4, 2025
View reviewed changes
conn-sdk-cli/readmegen/testdata/test1want.md Outdated Show resolved Hide resolved
conn-sdk-cli/readmegen/generate.go Outdated Show resolved Hide resolved
@hariso hariso enabled auto-merge (squash) February 4, 2025 13:06
@hariso hariso requested review from lovromazgon and raulb February 4, 2025 13:06
lovromazgon
lovromazgon approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but looks good!

conn-sdk-cli/readmegen/templates/parameters.table.tmpl Outdated Show resolved Hide resolved
conn-sdk-cli/readmegen/templates/parameters.yaml.tmpl Outdated Show resolved Hide resolved
@hariso hariso merged commit 6e80a87 into main Feb 4, 2025
3 checks passed
@hariso hariso deleted the haris/readmegen-show-if-param-required branch February 4, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@raulb raulb Awaiting requested review from raulb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hariso @raulb @lovromazgon