Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connector protocol and adjust code #142

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Update connector protocol and adjust code #142

merged 4 commits into from
Jun 10, 2024

Conversation

lovromazgon
Copy link
Member

Description

Updates the connector protocol and adjusts the code accordingly. It also updates all config types from a map[string]string to config.Config, which should make it simpler to discover config utilities when needed.

Depends on ConduitIO/conduit-connector-protocol#94.

Part of ConduitIO/conduit#1433.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same
    update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner May 28, 2024 13:14
@lovromazgon lovromazgon enabled auto-merge (squash) June 10, 2024 14:32
@lovromazgon lovromazgon merged commit ef4f939 into main Jun 10, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/cpluginv2-again branch June 10, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovromazgon @raulb