Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use html.isRaw method when appending child Markup instances #3

Merged
merged 1 commit into from
Apr 16, 2018
Merged

fix: use html.isRaw method when appending child Markup instances #3

merged 1 commit into from
Apr 16, 2018

Conversation

pgoldrbx
Copy link

@pgoldrbx pgoldrbx commented Apr 14, 2018 •
edited
Loading

Fixes issue filed upstream as benjycui#9

  • Use isRaw from html interface

This fixes the error thrown when isRaw is undefined

@pgoldrbx pgoldrbx self-assigned this Apr 14, 2018
@pgoldrbx pgoldrbx added the bug Something isn't working label Apr 14, 2018
@pgoldrbx pgoldrbx merged commit 9d0c9e2 into CondeNast:master Apr 16, 2018
@pgoldrbx pgoldrbx deleted the fix/raw-child branch April 26, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taveras taveras taveras approved these changes

@gautamarora gautamarora Awaiting requested review from gautamarora

Assignees

@pgoldrbx pgoldrbx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgoldrbx @taveras