Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AND-79 Fix WC crash loop #146

Merged
merged 4 commits into from
Oct 8, 2024
Merged

AND-79 Fix WC crash loop #146

merged 4 commits into from
Oct 8, 2024

Conversation

Radiokot
Copy link
Member

@Radiokot Radiokot commented Oct 8, 2024

Purpose

Fix a crash loop caused by a malformed WalletConnect verifiable presentation request

Changes

  • Check WC ID proof request nullability
  • Handle unexpected WC session request handling errors
  • Await the WC connection before sending responses

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Radiokot Radiokot merged commit a9ef461 into main Oct 8, 2024
1 check passed
@Radiokot Radiokot deleted the fix/AND-79-wc-crash-loop branch October 8, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants