Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q3 2023 documentation refactoring #875

Merged
merged 43 commits into from
Oct 2, 2023
Merged

Q3 2023 documentation refactoring #875

merged 43 commits into from
Oct 2, 2023

Conversation

dg-concordium
Copy link
Contributor

@dg-concordium dg-concordium commented Aug 25, 2023

Purpose

Restructuring the dev doc site to make it easier for users

Changes

Single downloads file, restructuring of sidebar, change top nav menu links

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dg-concordium dg-concordium added the preview Trigger a documentation preview for a PR. label Sep 1, 2023
@dg-concordium dg-concordium linked an issue Sep 6, 2023 that may be closed by this pull request
@Concordium Concordium deleted a comment from github-actions bot Sep 18, 2023
@dg-concordium dg-concordium removed the preview Trigger a documentation preview for a PR. label Sep 18, 2023
@limemloh
Copy link
Collaborator

limemloh commented Sep 19, 2023

Overall, I think it is an improvement.
Here are some findings:

The tooltips are not really readable:
Screenshot_20230919_104913

The hover menus in the top are nice from a computer, but I don't think they can be used from a touchscreen, and they are not accessible when the screen is small.

source/mainnet/conf.py Outdated Show resolved Hide resolved
@Concordium Concordium deleted a comment from github-actions bot Sep 19, 2023
@dg-concordium dg-concordium removed the preview Trigger a documentation preview for a PR. label Sep 19, 2023
@dg-concordium dg-concordium added the preview Trigger a documentation preview for a PR. label Sep 19, 2023
@Concordium Concordium deleted a comment from github-actions bot Sep 19, 2023
@dg-concordium dg-concordium added preview Trigger a documentation preview for a PR. and removed preview Trigger a documentation preview for a PR. labels Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-02 11:47 UTC

@dg-concordium dg-concordium merged commit 91ed359 into main Oct 2, 2023
2 checks passed
@dg-concordium dg-concordium deleted the q3-2023-refactoring branch October 2, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Trigger a documentation preview for a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation brand identity
2 participants