NOD-525: Optimize baker finalization awake updates #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
td202
approved these changes
Feb 13, 2025
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
|
If you haven't, could you double check that we have appropriate test coverage for this? e.g. if you break the test for skipping the update then it gets caught by some test. |
Prevent redundant writes in bsoMarkFinalizationAwakeBakers by only updating BakerPoolRewardDetails when a baker's finalization state actually changes. This avoids unnecessary tree rehashing on each block. Technical details: - Added check before updating BakerPoolRewardDetails
drsk0
force-pushed
the
optimize_mark_finalization_awake_bakers
branch
from
677586c to
b2ed3ae
Compare
|
@td202 I can't find any coverage for this. Do you have an idea where this could be tested? |
|
I added a test to |
drsk0
force-pushed
the
optimize_mark_finalization_awake_bakers
branch
from
0bbf0f0 to
ee40d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent redundant writes in bsoMarkFinalizationAwakeBakers by only updating BakerPoolRewardDetails when a baker's finalization state actually changes. This avoids unnecessary tree rehashing on each block.
Technical details:
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.