NOD-525: Optimize PoolRewards with cached hashing #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace BufferedRef with HashedBufferedRef in PoolRewards' bakerPoolRewardDetails LFMBTree to cache computed hashes. This optimization eliminates redundant hash calculations previously performed for each block. Technical details: - Switched from BufferedRef to HashedBufferedRef - Affects bakerPoolRewardDetails tree in PoolRewards data
drsk0
force-pushed
the
hashed_buffered_reference
branch
from
13a66ed to
9ede7bf
Compare
td202
approved these changes
Feb 13, 2025
|
Updated the Changelog. @td202 what's our policies for when to update the Changelog? This seemed more like a technical detail to me. |
drsk0
force-pushed
the
hashed_buffered_reference
branch
from
decd1f4 to
d2d38e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace BufferedRef with HashedBufferedRef in PoolRewards' bakerPoolRewardDetails LFMBTree to cache computed hashes. This optimization eliminates redundant hash calculations previously performed for each block.
Technical details:
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.