-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing SuspensionInfo and suspension chain parameters #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsk0
changed the title
introducion SuspensionInfo and suspension chain parameters
Introducing SuspensionInfo and suspension chain parameters
Dec 2, 2024
drsk0
force-pushed
the
suspension_info
branch
from
December 2, 2024 16:32
b7404a1
to
f0441c0
Compare
drsk0
force-pushed
the
suspension_info
branch
from
December 3, 2024 10:47
f0441c0
to
3984867
Compare
td202
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base submodule requires updating.
I'll update base as soon as the corresponding PR's there are merged. |
td202
requested changes
Dec 4, 2024
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState/Updates.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
td202
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
These are the corresponding changes for the newly introduced validator suspension chain parameters in the node repo. Also a data structure
SuspensionInfo
is introduced that gathers the missed rounds and whether a validator is primed for suspension at the next snapshot.Changes
See above
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.