Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed rounds #1245

Merged
merged 38 commits into from
Nov 12, 2024
Merged

Missed rounds #1245

merged 38 commits into from
Nov 12, 2024

Conversation

drsk0
Copy link
Contributor

@drsk0 drsk0 commented Oct 16, 2024

Purpose

Compute the missed rounds for validators and update them in the scheduler.

Changes

See above

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@drsk0 drsk0 requested a review from eb-concordium October 16, 2024 07:43
@drsk0 drsk0 force-pushed the suspend_resume_configure_baker branch 2 times, most recently from 0eda6ae to be864c2 Compare October 17, 2024 13:13
Base automatically changed from suspend_resume_configure_baker to main October 21, 2024 09:01
@drsk0 drsk0 force-pushed the missed_rounds branch 3 times, most recently from bd0dc99 to 94c9f4a Compare October 22, 2024 12:45
@drsk0 drsk0 marked this pull request as ready for review October 23, 2024 08:28
@drsk0 drsk0 requested a review from td202 October 23, 2024 10:48
@drsk0 drsk0 force-pushed the missed_rounds branch 7 times, most recently from ce3ea9a to f3fbeaa Compare October 29, 2024 20:55
@drsk0 drsk0 requested a review from td202 October 30, 2024 11:46
@drsk0 drsk0 force-pushed the missed_rounds branch 7 times, most recently from 8c77619 to e55f767 Compare November 6, 2024 17:08
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the main thing is to add/update testing for rotating the capital distribution.

@drsk0 drsk0 force-pushed the missed_rounds branch 3 times, most recently from 876fd34 to 71a853b Compare November 7, 2024 17:02
@drsk0 drsk0 force-pushed the missed_rounds branch 2 times, most recently from 662d997 to 6d4efed Compare November 11, 2024 14:44
@drsk0 drsk0 force-pushed the missed_rounds branch 2 times, most recently from 4e8095a to 3b5c2b8 Compare November 11, 2024 16:28
drsk added 2 commits November 12, 2024 14:57
This contained a recursive definition.
@drsk0 drsk0 merged commit c41af00 into main Nov 12, 2024
3 checks passed
@drsk0 drsk0 deleted the missed_rounds branch November 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants