-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed rounds #1245
Merged
Merged
Missed rounds #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
2 times, most recently
from
October 17, 2024 13:13
0eda6ae
to
be864c2
Compare
drsk0
force-pushed
the
missed_rounds
branch
3 times, most recently
from
October 22, 2024 12:45
bd0dc99
to
94c9f4a
Compare
td202
reviewed
Oct 24, 2024
concordium-consensus/src/Concordium/KonsensusV1/Consensus/Blocks.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/Consensus/Blocks.hs
Outdated
Show resolved
Hide resolved
drsk0
force-pushed
the
missed_rounds
branch
7 times, most recently
from
October 29, 2024 20:55
ce3ea9a
to
f3fbeaa
Compare
td202
reviewed
Nov 5, 2024
drsk0
force-pushed
the
missed_rounds
branch
7 times, most recently
from
November 6, 2024 17:08
8c77619
to
e55f767
Compare
td202
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the main thing is to add/update testing for rotating the capital distribution.
concordium-consensus/src/Concordium/GlobalState/Persistent/PoolRewards.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/LeaderElection.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
drsk0
force-pushed
the
missed_rounds
branch
3 times, most recently
from
November 7, 2024 17:02
876fd34
to
71a853b
Compare
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
drsk0
force-pushed
the
missed_rounds
branch
2 times, most recently
from
November 11, 2024 14:44
662d997
to
6d4efed
Compare
drsk0
force-pushed
the
missed_rounds
branch
2 times, most recently
from
November 11, 2024 16:28
4e8095a
to
3b5c2b8
Compare
This contained a recursive definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Compute the missed rounds for validators and update them in the scheduler.
Changes
See above
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.