-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cooldown changes #1175
Cooldown changes #1175
Conversation
… cooldowns on accounts.
concordium-consensus/tests/scheduler/SchedulerTests/Delegation.hs
Outdated
Show resolved
Hide resolved
I pushed a fix to the consensus, because it didn't actually recognize the P7 protocol update. I'm not really sure why I didn't see this when I was testing the P6 to P7 update, where it seemed to work fine, but for P7 to P7 it did not work. In any case, it should be fixed now. I also changed it from using a wildcard pattern match to avoid future problems like this. I tested the update with this fix and tried the (newly updated) state compare tool as well on the protocol update and it seemed to work perfectly fine. |
…ccount-migration-fix
Account migration fix
Consensus exception handling
Fix the payday timing at the P6->P7 protocol update.
…he genesis block after a state migration.
Purpose
Closes #1142 #1145
Implement cooldown changes in the node.
Changes
bsoConfigureBaker
intobsoAddValidator
andbsoUpdateValidator
. Rewrite to factor out the checks and to make the flow of account updates more apparent.bsoUpdateValidator
is changed in the following case: when the validator's keys are changed, and the new aggregation key duplicates the aggregation key of some other validator, the key that is actually duplicated is now returned (whereas previously the old key on the account was returned) in the error. This causes a difference in the RejectReason which is reported for such a transaction, and could cause incompatibility if such a difference was observed in P1-P4 (since P5, reject reasons are not included in the block hashing scheme). (This does not seem to have occurred at least on mainnet.)bsoConfigureDelegation
intobsoAddDelegator
andbsoUpdateDelegator
. Rewrite to factor out the checks and to make the flow of account updates more apparent.bsoConfigureBaker
andbsoConfigureDelegation
(see the branch: https://github.com/Concordium/concordium-node/tree/backport-tests).Checklist
hard-to-understand areas.