Prepared statements issue #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victor-N-Suadicani
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
I guess it's fine?
More long term, we really should switch to a framework like sqlx which handles prepared queries and caching completely automatically.
I will write a task on that: https://linear.app/concordium/issue/MIS-93/cleanup-use-sqlx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Global prepared statement are causing issues when using them from another thread.
Changes
Always reinitialise prepared statements, but use cache to ensure to lower overhead.
Bump psql to version 14 because would only initialise version 11 as is. This might give issues.
Checklist
hard-to-understand areas.