Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wallet sdk bugs #320

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Fix wallet sdk bugs #320

merged 4 commits into from
Feb 21, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Feb 19, 2024

Purpose

Fix nonce issue in example wallet (breaking change from the SDK) and fix a bug in ConcordiumHdWallet.fromSeedPhrase where the generated seed was invalid (contained spaces).

Changes

  • Use other nonce type.
  • Remove spaces in seed as hex.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj marked this pull request as ready for review February 19, 2024 12:48
@orhoj orhoj merged commit 0812ecc into main Feb 21, 2024
2 checks passed
@orhoj orhoj deleted the fix-wallet-sdk-bugs branch February 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium