Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity request #295

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Identity request #295

merged 10 commits into from
Jan 18, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Jan 17, 2024

Purpose

Add function for generating an identity request.

Changes

  • JNI for accessing concordium-base functionality for creating an identity request.
  • Improved typing of PRF-key and IdCredSec on ConcordiumHdWallet.

Note: The identity request is just given as a String as that is all that is needed for sending it to the identity provider. In a later PR we may type it instead (we have another branch with the majority of the typing done).

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Base automatically changed from hd-wallet to main January 17, 2024 14:48
@orhoj orhoj marked this pull request as ready for review January 17, 2024 14:51
@orhoj orhoj requested a review from MilkywayPirate January 17, 2024 14:59
@orhoj orhoj merged commit b097582 into main Jan 18, 2024
2 checks passed
@orhoj orhoj deleted the identity-request branch January 18, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants