Merge pull request #326 from Concordium/bugfix-issue-324

Removed `tag` field from CustomEvent

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Changelog
 
 ## Unreleased changes
+- Fixed a bug in `CustomEvent`. Removed unnecessary `tag` field.
 - Added `Web3IdProof` class with `getWeb3IdProof` method to create Presentations. (And supporting classes)
 - Fixed an issue where `ConcordiumHdWallet.fromSeedPhrase` always produced an invalid seed as hex.
 

concordium-sdk/src/main/java/com/concordium/sdk/cis2/SerializationUtils.java

@@ -202,13 +202,13 @@ public static Cis2Event deserializeCis2Event(byte[] eventBytes) {
             case TOKEN_METADATA:
                 return SerializationUtils.deserializeTokenMetadataEvent(buffer);
             case CUSTOM:
-                return SerializationUtils.deserializeCustomEvent(tag, buffer);
+                return SerializationUtils.deserializeCustomEvent(buffer);
         }
         throw new IllegalArgumentException("Malformed CIS2 event");
     }
 
-    private static Cis2Event deserializeCustomEvent(byte tag, ByteBuffer buffer) {
-        return new CustomEvent(tag, buffer.array());
+    private static Cis2Event deserializeCustomEvent(ByteBuffer buffer) {
+        return new CustomEvent(buffer.array());
     }
 
     @SneakyThrows

concordium-sdk/src/main/java/com/concordium/sdk/cis2/events/CustomEvent.java

@@ -12,11 +12,9 @@
 @Getter
 public class CustomEvent implements Cis2Event {
 
-    private final byte tag;
     private final byte[] data;
 
-    public CustomEvent(byte tag, byte[] data) {
-        this.tag = tag;
+    public CustomEvent(byte[] data) {
         this.data = data;
     }