[BRO-39] Migrate away from injecting API (package) #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of walletApi usage as a separate package
Changes in this example:
Removed inject.js as proof of no side effects
Added webpack.config for wallet-api package
In general this is main part of example
This creates a fairly large build.
Because it depends on api-helpers and message-hub
With such an implementation, further migration to the new walletApi is quite simple
Just by removing asynchronous call of detectConcordiumProvider()
Old:
detectConcordiumProvider().then((provider) => provider.connect())
New:
walletApi.connect()
concordiumWalletApi.min.js does not contain part of functions from @concordium/web-sdk which leads to errors, example in two-step-transfer