-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable hdf5 chunking by default #3919
Disable hdf5 chunking by default #3919
Conversation
05cbb0a
to
e5c3410
Compare
Some fixes were needed, but I could now verify that this PR solves the issue that I saw on Hemera and Summit If someone really needs chunking, it should be possible by overriding this option in |
I've now verified that chunking can be re-enabled by setting |
b2290e9
to
1c113f7
Compare
For the moment this PR is ready for review.
|
IMO your solution is fine. To be fair we do not really care if HDF5 is using chunking or not. On most systems, we prefer to use ADIOS2 anyway. |
I thought so too, so I have no issue with just disabling that and having less trouble heading our way. There might be performance implications, but we never used chunking in the past either, and it's still available as an opt-in. |
@franzpoeschel Could You please resolve the merge conflict, I will set the CI to not compile all again because the conflict is in the documentation only. |
1c113f7
to
0ca679f
Compare
@psychocoderHPC done |
To make this more reproducible, can you confirm those please:
Why did you switch in modern OpenMPI versions from OpenMPI's MPIIO to ROMIO? I opened a couple of issues with OpenMPI on GitHub in the past, and they do not seem to recommend to do so (see my reports and discussion with JSC on Juwels Booster, for instance.) |
@psychocoderHPC and @franzpoeschel I think @ax3l's question is addressed to you. |
I should rerun these tests anyway because there's a chance that it's related to the issue fixed by openPMD/openPMD-api#1239. Will do and post more detailed results. |
We specify
export OMPI_MCA_io=^ompio
in some templates and that somehow makes HDF5 segfault when chunking is enabled. Chunking is only a recent addition in the openPMD-api so the error probably did not came up too often for now, but we should clarify this before merging this one.TODO: