-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce release template #121
Conversation
- feature | ||
- bug-fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added labels for these, https://github.com/ComposeGears/Valkyrie/labels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature!
Do I understand correctly that all tasks should be covered by the 'housekeeping' label?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✏️ Tasks
now contains all but feature
and bug-fix
(housekeeping
, dependencies
and other categories).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's process with this, I like automation 🌚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog generation into file can be useful for integration with this plugin feature: https://github.com/JetBrains/gradle-changelog-plugin
It allows to see changelog in Jetbrains marketplace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Goooler
Checked generated report, looks pretty nice, thanks for contribution ❤️
I see few things to improve:
- can we add "🆙 Dependencies" section based on label (for easy track changes)?
- is it possible to change title from "Nightly" to smth like "0.0.6-Nightly"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Yes we can.
- We can keep the version name like 0.0.6-SNAPSHOT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, perfect!
This is not urgent at all 🙂
https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes