Fix various clippy and compilation warnings #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my previous commit I’ve introduced a new build warning. Motivation for this commit was to fix it and while I’m at it address some other issues as well. However, turns out there’s too many warnings I care to deal with so this addresses only some of the warnings.
blasrodri
approved these changes
Nov 13, 2023
RustNinja
approved these changes
Nov 27, 2023
|
@RustNinja, could you also merge? I don’t have write permissions in the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous commit I’ve introduced a new build warning. Motivation
for this commit was to fix it and while I’m at it address some other
issues as well. However, turns out there’s too many warnings I care
to deal with so this addresses only some of the warnings.