Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu platforms to auditd_data_disk_error_action remediation #12928

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 29, 2025

Description:

  • Add ubuntu platforms to auditd_data_disk_error_action remediation

Tests:

Ubuntu 24.04.1 Desktop in KVM:

INFO - xccdf_org.ssgproject.content_rule_auditd_data_disk_error_action
INFO - Script wrong_value.fail.sh using profile (all) OK
INFO - Script correct_and_wrong_value_multiple_possible.fail.sh using profile (all) OK
INFO - Script correct_and_wrong_value_one_possible.fail.sh using profile (all) OK
INFO - Script correct_value_multiple_possible.pass.sh using profile (all) OK
INFO - Script no_value.fail.sh using profile (all) OK
INFO - Script correct_value_one_possible.pass.sh using profile (all) OK

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dodys dodys self-assigned this Jan 29, 2025
@dodys dodys requested a review from a team January 29, 2025 12:56
@dodys dodys added Bash Bash remediation update. Ubuntu Ubuntu product related. labels Jan 29, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 29, 2025
Copy link

codeclimate bot commented Jan 29, 2025

Code Climate has analyzed commit cb2f626 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit dc71fb3 into ComplianceAsCode:master Jan 29, 2025
98 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants