Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package and service name overrides for Ubuntu 24.04 #12913

Merged

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Jan 28, 2025

Description:

  • Fix package and service name overrides for Ubuntu 24.04

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 28, 2025
Copy link

openshift-ci bot commented Jan 28, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codeclimate bot commented Jan 28, 2025

Code Climate has analyzed commit 7e7e90d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys requested a review from a team January 28, 2025 10:34
@dodys dodys self-assigned this Jan 28, 2025
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Jan 28, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 28, 2025
@dodys dodys added the Update Rule Issues or pull requests related to Rules updates. label Jan 28, 2025
@mpurg
Copy link
Contributor Author

mpurg commented Jan 29, 2025

Automatus fails on rule package_rsh_removed because rsh-client can no longer be installed from the Ubuntu 24.04 repos. I think we can safely ignore it. I filed a ticket with CIS: https://workbench.cisecurity.org/benchmarks/18959/tickets/23742

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 3d56527 into ComplianceAsCode:master Jan 29, 2025
92 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants