Change shellcheck tests #12848
Merged
Change shellcheck tests #12848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
|
The shellcheck tests take a lot of time, each of them up to 20 seconds. This commit does the following changes: 1. Disable the data flow analysis. The data flow analysis can find more issues but is slow. 2. Don't mark the test as quick.
jan-cerny
force-pushed
the
shellcheck_downgrade
branch
from
7d2a8ff to
d478e31
Compare
|
Still seems there is some sort of issue with the new check.
|
|
I have tried to change my approach so that there is no variable involved and not pass an empty string to shellcheck wrapper. |
|
Code Climate has analyzed commit b7d2d12 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
|
/packit build |
Mab879
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shellcheck tests take a lot of time, each of them up to 20 seconds. This commit does the following changes: