Remove deprecated IBM finding plugin #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cletomartin
requested review from
alfinkel,
drsm79,
mattwhite and
smithsz
as code owners
cletomartin
commented
Jul 29, 2024
| @@ -861,7 +856,9 @@ def _send_message(self, message, channels): | |||
| retries = self._config.get("retries", 3) | |||
| retry = 0 | |||
| while retry < retries: | |||
| response = requests.post(url, headers=headers, data=json.dumps(msg)) | |||
| response = requests.post( | |||
| url, headers=headers, data=json.dumps(msg), timeout=180 | |||
There was a problem hiding this comment.
This makes bandit happier.
cletomartin
force-pushed
the
remove-IBM-findings-notifier
branch
from
ae82e5e
to
8749ce8
Compare
drsm79
previously approved these changes
Jul 29, 2024
BREAKING CHANGES: this notifier will be removed. Seems like ibm_cloud_security_advisor is [now deprecated](https://github.com/ibm-cloud-security/security-advisor-sdk-python/). It is having issues compatibility issues with Python 3.12.
cletomartin
force-pushed
the
remove-IBM-findings-notifier
branch
from
8749ce8
to
55b7f4e
Compare
drsm79
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Seems like ibm_cloud_security_advisor is now deprecated. It is having issues compatibility issues with Python 3.12.
How
ibm_cloud_security_advisoras a dependency.Test
Test passing locally.