Skip to content
This repository has been archived by the owner on Feb 18, 2023. It is now read-only.

Support Nova 4 and php 8+ #20

Merged
merged 3 commits into from
May 10, 2022
Merged

Support Nova 4 and php 8+ #20

merged 3 commits into from
May 10, 2022

Conversation

max-zu
Copy link

@max-zu max-zu commented Apr 22, 2022

Support Nova 4 and php 8+

@micc83
Copy link
Contributor

micc83 commented May 2, 2022

Hi @max-zu, thank you for the PR. Unfortunately we still haven't bought a license for Nova 4 so we have no way to test it out.

@micc83 micc83 linked an issue May 5, 2022 that may be closed by this pull request
@micc83 micc83 mentioned this pull request May 5, 2022
@bogomya
Copy link

bogomya commented May 6, 2022

@micc83 , just tested, works fine, can we create a draft release, so then it will be available for everyone to use ?

@micc83
Copy link
Contributor

micc83 commented May 9, 2022

Hello @bogomya, sure and yet we don't feel comfortable releasing a new prod version without having tested it accurately. We're thinking about releasing an alpha so that anyone can decide whether it is worth the risk.

@bogomya
Copy link

bogomya commented May 9, 2022

Hi @micc83 , thanks, would be really nice to have an alfa version to start using nova-help with Nova 4

@micc83 micc83 changed the base branch from master to develop May 10, 2022 11:25
@micc83 micc83 merged commit 41b444a into Comodolab:develop May 10, 2022
@micc83
Copy link
Contributor

micc83 commented May 10, 2022

Until we figure out next steps to take I merged it with the develop branch so it can be used with dev-develop.

@micc83
Copy link
Contributor

micc83 commented May 10, 2022

We've also released 0.6.0-alpha.

@tassilogroeper
Copy link

Thanks @micc83 for the release. As far as I can tell, the styling is broken, due to the change to inertia and Tailwinds JIT in nova-4. The current solution should be Scoped Styles, as described by @jimarick

laravel/nova-issues#4061 (comment)

@micc83
Copy link
Contributor

micc83 commented Aug 30, 2022

@tassilogroeper Unfortunately by now we're pretty sure we'll not invest anymore in the upgrade to Nova 4 or, more in general, in the development of the plugin. We're currently looking for a new trusted maintainer to transfer the project. I'll update you all as soon as I have some news. Thank you for your interest.

@micc83 micc83 mentioned this pull request Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility Nova 4 ?
4 participants