Fix Windows Media Element in MultiWindow Mode on exit Crash

[ne0rrmatrix]

• Bug fix

Description of Change

Track window count and manage snackbar notifications

Added a static NumberOfWindows property to the Options class to track the number of windows. Updated SetShouldEnableSnackbarOnWindows to increment/decrement NumberOfWindows on window creation/closure. Conditional registration/unregistration of AppNotificationManager for snackbar notifications based on NumberOfWindows count.

Linked Issues

• Fixes [BUG] Media Element Multi-Window Page crash on app exit #2257
• Fixes Application crashes upon closing a second window when using Builder.options.SetShouldEnableSnackbarOnWindows(true)  #2279

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

This PR uses a simple counter to track the number of windows that exist and only when one is remaining will it unregister Snackview

[McSaverInvestments]

This changed fixed #2279
Hoping it will be released soon

[pictos]

I'm not sure if just the UIThread can create an window or if can be done by another thread. I believe that's the second, so the Window1.UIThread != Window2.UIThread, and that can cause concurrency issues.

I would suggest to use the Interlocked.Increment and Interlocked.Decrement to control this counter

[brminnick]

Good catch! Interlocked.Increment and Interlocked.Decrement are perfect for this scenario.

In this implementation, I think we should actually remove internal static int NumberOfWindows { get; private set; } and use Application.Current.Windows.Count to avoid creating a duplicate property forcing CommunityToolkit.Maui to increment/decrement properly.

I don't see a problem removing internal static in Options.NumberOfWindows { get; } since it is not being used anywhere else in the code.

I'll update the code to remove this property 👍

[ne0rrmatrix]

Are we going to go ahead and use else if (Application.Current.Windows.Count is 1) and not switch to Interlocked.Increment and Interlocked.Decrement. I am happy either way but it would be nice to resolve this.

[McSaverInvestments]

Can some please resolve this merge conflict?
We have waiting on this for quite sometime!
@brminnick @ne0rrmatrix @pictos @softlion

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

[McSaverInvestments]

I am new to this process, and don't understand who needs to do what to get this done, but I would appreciate any help to get the mission accomplished.

@brminnick @ne0rrmatrix @pictos @softlion