Skip to content

Commit

Permalink
[native] Upgrade to [email protected]
Browse files Browse the repository at this point in the history
Summary: Was investigating if this introduce support in Hermes for named capture groups to address some issues integrating Viem in [ENG-5308](https://linear.app/comm/issue/ENG-5308/use-ensjs-for-batch-ens-lookups-in-order-to-support-ensip-10-wildcard). It didn't end up helping, but I figured I'd put the diff up anyways.

Test Plan: Before landing, will confirm it passes CI, and that iOS / Android builds on dev / release

Reviewers: varun, will

Reviewed By: will

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13700
  • Loading branch information
Ashoat committed Oct 15, 2024
1 parent d44364d commit ea4b0ba
Show file tree
Hide file tree
Showing 6 changed files with 551 additions and 433 deletions.
15 changes: 15 additions & 0 deletions native/ios/Comm.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1847,6 +1847,7 @@
"DEBUG=1",
"FB_SONARKIT_ENABLED=1",
"$(inherited)",
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION,
);
GCC_SYMBOLS_PRIVATE_EXTERN = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
Expand All @@ -1866,6 +1867,11 @@
"-fcxx-modules",
"-fmodules",
);
OTHER_LDFLAGS = (
"$(inherited)",
"-Wl",
"-ld_classic",
);
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
};
Expand Down Expand Up @@ -1906,6 +1912,10 @@
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_PREPROCESSOR_DEFINITIONS = (
"$(inherited)",
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION,
);
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
Expand All @@ -1922,6 +1932,11 @@
"-fcxx-modules",
"-fmodules",
);
OTHER_LDFLAGS = (
"$(inherited)",
"-Wl",
"-ld_classic",
);
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
SWIFT_COMPILATION_MODE = wholemodule;
Expand Down
3 changes: 0 additions & 3 deletions native/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ post_install do |installer|
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'NO'
# The below is to address: https://linear.app/comm/issue/ENG-4984
# Context: https://github.com/facebook/react-native/issues/37748
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] ||= ['$(inherited)', '_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION']
end
end

Expand Down
Loading

0 comments on commit ea4b0ba

Please sign in to comment.