-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: With the introduction of the farcasterBot, it's possible for a user to be added to a community and not have this community in their communityStore. in this scenario, the UpdateHandler should handle adding the community thread to the threadStore. the handler in this diff will check if any of the COMMUNITY_ROOT threads are missing in the communityStore. If there are missing communities, callFetchCommunityInfos is invoked Test Plan: applied [this patch](https://gist.github.com/vdhanan/b1d65616283f69c801d4057bc4aceffd) and confirmed with logs that my handler was invoked. also confirmed that communityStore was immediately updated and thread avatars were immediately rendered Reviewers: will, ashoat Reviewed By: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13810
- Loading branch information
Showing
3 changed files
with
80 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
// @flow | ||
|
||
import * as React from 'react'; | ||
|
||
import { | ||
useFetchCommunityInfos, | ||
fetchCommunityInfosActionTypes, | ||
} from '../actions/community-actions.js'; | ||
import { isLoggedIn } from '../selectors/user-selectors.js'; | ||
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js'; | ||
import { FetchTimeout } from '../utils/errors.js'; | ||
import { useDispatchActionPromise } from '../utils/redux-promise-utils.js'; | ||
import { useSelector } from '../utils/redux-utils.js'; | ||
|
||
function SyncCommunityStoreHandler(): React.Node { | ||
const loggedIn = useSelector(isLoggedIn); | ||
const threadInfos = useSelector(state => state.threadStore.threadInfos); | ||
const communityInfos = useSelector( | ||
state => state.communityStore.communityInfos, | ||
); | ||
const callFetchCommunityInfos = useFetchCommunityInfos(); | ||
const dispatchActionPromise = useDispatchActionPromise(); | ||
|
||
const requestedCommunityInfosRef = React.useRef(new Set<string>()); | ||
|
||
React.useEffect(() => { | ||
if (!loggedIn) { | ||
return; | ||
} | ||
|
||
const communityRootThreads = Object.values(threadInfos).filter(thread => | ||
threadTypeIsCommunityRoot(thread.type), | ||
); | ||
|
||
const missingCommunityInfos = communityRootThreads.filter( | ||
thread => | ||
!(thread.id in communityInfos) && | ||
!requestedCommunityInfosRef.current.has(thread.id), | ||
); | ||
|
||
if (missingCommunityInfos.length === 0) { | ||
return; | ||
} | ||
|
||
missingCommunityInfos.forEach(thread => | ||
requestedCommunityInfosRef.current.add(thread.id), | ||
); | ||
|
||
const fetchCommunityInfosPromise = (async () => { | ||
try { | ||
return await callFetchCommunityInfos(); | ||
} catch (e) { | ||
if (e instanceof FetchTimeout) { | ||
missingCommunityInfos.forEach(thread => | ||
requestedCommunityInfosRef.current.delete(thread.id), | ||
); | ||
} | ||
throw e; | ||
} | ||
})(); | ||
void dispatchActionPromise( | ||
fetchCommunityInfosActionTypes, | ||
fetchCommunityInfosPromise, | ||
); | ||
}, [ | ||
callFetchCommunityInfos, | ||
communityInfos, | ||
dispatchActionPromise, | ||
loggedIn, | ||
threadInfos, | ||
]); | ||
|
||
return null; | ||
} | ||
|
||
export default SyncCommunityStoreHandler; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters