Skip to content

Commit

Permalink
[comm-lib] Hide aws behind a feature flag
Browse files Browse the repository at this point in the history
Summary: While we used aws dependencies in all services, future diffs will make `comm-lib` a (transitive) dependency of `native_rust_library`. These dependencies aren't needed there so I'm introducing a new feature flag that hides them and the modules that depend on aws crates.

Test Plan: Check that all services compile

Reviewers: bartek, varun, kamil

Reviewed By: bartek, varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10258
  • Loading branch information
MichalGniadek committed Dec 19, 2023
1 parent 4d5b4f6 commit a05bedf
Show file tree
Hide file tree
Showing 9 changed files with 65 additions and 563 deletions.
1 change: 1 addition & 0 deletions services/backup/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ clap = { version = "4.0", features = ["derive", "env"] }
comm-lib = { path = "../../shared/comm-lib", features = [
"http",
"blob-client",
"aws",
] }
once_cell = "1.17"
tokio = { version = "1.24", features = ["rt-multi-thread", "macros"] }
Expand Down
2 changes: 1 addition & 1 deletion services/blob/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ aws-sdk-dynamodb = "0.27"
aws-sdk-s3 = "0.27"
chrono = "0.4.31"
clap = { version = "4.0", features = ["derive", "env"] }
comm-lib = { path = "../../shared/comm-lib", features = ["http"] }
comm-lib = { path = "../../shared/comm-lib", features = ["http", "aws"] }
derive_more = "0.99"
http = "0.2"
once_cell = "1.17"
Expand Down
Loading

0 comments on commit a05bedf

Please sign in to comment.