[native] Make sure all virtual classes in C++ code base have virtual …

…destructor Summary: https://linear.app/comm/issue/ENG-2329/make-sure-all-virtual-classes-in-c-code-base-have-virtual-destructor Test Plan: Compile the app and make sure there are no more warnings related to missing virtual destructors Reviewers: kamil, tomek Reviewed By: kamil Subscribers: ashoat Differential Revision: https://phab.comm.dev/D13950
CommE2E · Nov 19, 2024 · 7a60852 · 7a60852
1 parent d3f8dfe
commit 7a60852
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h b/native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
@@ -190,6 +190,7 @@ class DatabaseQueryExecutor {
       std::optional<std::string> messageIDCursor) const = 0;
   virtual std::vector<MessageEntity> getRelatedMessagesForSearch(
       const std::vector<std::string> &messageIDs) const = 0;
+  virtual ~DatabaseQueryExecutor() = default;
 
 #ifdef EMSCRIPTEN
   virtual std::vector<WebThread> getAllThreadsWeb() const = 0;

diff --git a/...eModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MessageSpec.h b/...eModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs/MessageSpec.h
@@ -11,5 +11,7 @@ class MessageSpec {
 public:
   virtual std::unique_ptr<std::string>
   messageContentForClientDB(const folly::dynamic &rawMessageInfo) = 0;
+  virtual ~MessageSpec() {
+  }
 };
 } // namespace comm
diff --git a/web/shared-worker/_generated/comm_query_executor.wasm b/web/shared-worker/_generated/comm_query_executor.wasm