Skip to content

Commit

Permalink
[landing] Set redirectUrl so that Warpcast redirects back to Comm
Browse files Browse the repository at this point in the history
Summary:
[Thank you](farcasterxyz/auth-monorepo#157) @deodad for this one-line change 🙏

`back-from-warpcast` here is just a random string. `DeepLinksContextProvider` does nothing if it can't parse the URL, and in this case we're okay with that since we only call Warpcast when Comm is on the "Connect Farcaster" screen.

Depends on D13579

Test Plan: Testing the Farcaster connection screen in a dev environment is kind of complicated, so I created [this doc on Notion](https://www.notion.so/commapp/How-to-test-Farcaster-connect-screen-114d823c518b80cf9b10da4d961bc807). I followed the instructions there for both physical iOS and Android devices

Reviewers: varun, will

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13580
  • Loading branch information
Ashoat committed Oct 3, 2024
1 parent c4a4e93 commit 48a911c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions landing/connect-farcaster.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const config = {
siweURL: 'https://comm.app/connect-farcaster',
rpcURL: 'https://mainnet.optimism.io',
relay: 'https://relay.farcaster.xyz',
redirectUrl: 'comm://back-from-warpcast',
};

function postMessageToNativeWebView(message: FarcasterWebViewMessage) {
Expand Down

0 comments on commit 48a911c

Please sign in to comment.