Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[native] update baseNoDataAfterPolicyAcknowledgmentSelector check
Summary: Discovered while looking at [ENG-5883](https://linear.app/comm/issue/ENG-5883/rahul-sees-socket-crash-loop-due-to-policy-acceptance-issue). This selector was not sufficiently specific; we should not only verify that all policies are accepted but also check if any policy has been accepted. The previous version could inaccurately return a truthy value in cases other than the absence of data following policy acknowledgment. Note: In most standard use cases, userPolicies is empty. It's only populated when policies need to be accepted with falsy flags, and right after acknowledgment, to handle cases such as this one. Test Plan: 1. Test policies mechanism 2. Test policies with socket issues 3. Make sure in other cases this condition is falsy Reviewers: tomek, michal, inka Reviewed By: tomek Subscribers: ashoat Differential Revision: https://phab.comm.dev/D9965
- Loading branch information