Skip to content

Commit

Permalink
[lib] Stop shimming Blob-hosted multimedia messages
Browse files Browse the repository at this point in the history
Summary: Points 3a and 3b from [[ https://linear.app/comm/issue/ENG-6459/launch-of-encrypted-media#comment-974e1b67 | ENG-6459 ]].

Test Plan: Replaced next code version constant with a past version and verified that robotext no longer appears and blob-hosted media messages are displayed.

Reviewers: ashoat

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13888
  • Loading branch information
barthap committed Nov 7, 2024
1 parent caf1601 commit 0b058dc
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions lib/shared/messages/multimedia-message-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import {
} from '../../utils/message-ops-utils.js';
import { createMediaMessageInfo } from '../message-utils.js';
import { threadIsGroupChat } from '../thread-utils.js';
import { FUTURE_CODE_VERSION, hasMinCodeVersion } from '../version-utils.js';
import { NEXT_CODE_VERSION, hasMinCodeVersion } from '../version-utils.js';

type MultimediaMessageSpec = MessageSpec<
MediaMessageData | ImagesMessageData,
Expand Down Expand Up @@ -253,7 +253,7 @@ export const multimediaMessageSpec: MultimediaMessageSpec = Object.freeze({
) {
return messageInfo;
}
if (hasMinCodeVersion(platformDetails, { native: FUTURE_CODE_VERSION })) {
if (hasMinCodeVersion(platformDetails, { native: NEXT_CODE_VERSION })) {
return messageInfo;
}

Expand Down Expand Up @@ -292,9 +292,6 @@ export const multimediaMessageSpec: MultimediaMessageSpec = Object.freeze({
};
} else if (unwrapped.type === messageTypes.MULTIMEDIA) {
for (const media of unwrapped.media) {
if (isMediaBlobServiceHosted(media)) {
return messageInfo;
}
const { type } = media;
if (
type !== 'photo' &&
Expand Down

0 comments on commit 0b058dc

Please sign in to comment.