Skip to content

Commit

Permalink
[commtest] Fix code version for grpc client tests
Browse files Browse the repository at this point in the history
Summary:
Identity service has min-version hardcoded to `270` while the test was providing 100, which caused failure due to "Unsupported version".
Changed it to 1000 to give us some time. When it fails next time we can bump it up again, unless we have better ways of setting the value.

Test Plan: The test no longer fails

Reviewers: varun, jon

Reviewed By: varun

Subscribers: ashoat, tomek, wyilio

Differential Revision: https://phab.comm.dev/D9531
  • Loading branch information
barthap committed Oct 20, 2023
1 parent f5b43a5 commit 06f338b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion services/commtest/tests/grpc_client_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use commtest::{identity::device::create_device, service_addr};
async fn verify_access_token() {
use grpc_clients::identity::unauthenticated::client::verify_user_access_token;
let device_info = create_device(None).await;
let code_version = 100;
let code_version = 1000;
let device_type = "android";

let token_valid = verify_user_access_token(
Expand Down

0 comments on commit 06f338b

Please sign in to comment.