feat: modernize js and add connect bar styles

[sanoojes]

before:

after:

[ohitstom]

make this an option in the settings menu, it's supposed to be long like that in the first place

name it something like "compact connect bar"

[sanoojes]

Sure, I will add a setting for a 'Compact Connect Bar'!
Also, making the default 'Now Playing' connect bar appear like this will enhance the theme's aesthetic.

Thinking of doing something like this

  .main-connectBar-connectBar {
    --gap: 1rem;
    width: calc(94% - var(--gap, 0.5rem));
    margin-left: auto;
  }

[ohitstom]

make any changes you think will enhance it! but for the extremely compact one make it a settings menu thing :) I'll be home tomorrow evening to check this out

[sanoojes]

Sure, I'll add it soon. I'm not home right now.

[sanoojes]

btw where is the connect bar located by default ?

[ohitstom]

the same place it is currently in comfy except below the play bar, which obviously looks weird with comfy because we move it down and stretch it out! so we just put it on top instead

[sanoojes]

I also added a toggle for a compact connect bar next to the "Remove Connect Bar" option. The default connect bar now has this style, which I believe looks better.

[ohitstom]

looks good at face value, will test and merge these changes in a couple days!

[sanoojes]

Great !

[sanoojes]

ohh what a coincidence i was resolving the conflicts

[ohitstom]

ohh what a coincidence i was resolving the conflicts

haha, in the process of testing the pr now will get back to you!

[sanoojes]

sure !

[ohitstom]

im not a super big fan of all the random formatting changes you have made, is there a reason why? i try to stick to the current prettier config we have in the repo - what have you run across all these files?

[ohitstom]

the compact bar thing doesnt seem to work on Spotify for Windows (64 bit)
1.2.47.364.gf06e5cee

[sanoojes]

i didn't test it on the newer versions i will check that out soon

[sanoojes]

im not a super big fan of all the random formatting changes you have made, is there a reason why? i try to stick to the current prettier config we have in the repo - what have you run across all these files?

oops idk why my prettier did that i think it was overwritten by biome

[sanoojes]

Thanks !

[ohitstom]

i didn't test it on the newer versions i will check that out soon

got it! though if there is no valid reason for all the formatting changes i prefer the original, especially the channels variable definition before and after for example, thoughts?

[sanoojes]

ohh alright
wdm by channels variable definition ? i didn't quite get that

[ohitstom]

ohh alright wdm by channels variable definition ? i didn't quite get that

in theme.script.js the const channels var, look at how it looks before vs after your pr:

[sanoojes]

ohh alright !

[ohitstom]

alright im happy with everything else so far but whatever you changed to do with updateScheme function has broken the color scheme setting from ever showing up in the settings menu, once you've fixed that im happy to merge

[sanoojes]

alright im happy with everything else so far but whatever you changed to do with updateScheme function has broken the color scheme setting from ever showing up in the settings menu, once you've fixed that im happy to merge

I've identified that the problem
i didn't update the loop in parseIni() function.

[ohitstom]

please see my mention on discord for further instructions before i can merge!

[sanoojes]

alright am checking it rn !