update userdata file endpoints to use query parameters instead of path #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope the tests will pass if the linked PR gets merged into ComfyUI. What’s your take on these changes? If the idea was that ComfyUI isn’t meant to support NGINX, Caddy, or other reverse proxies, it might be worth mentioning that in the README since people usually expect it to work with reverse proxies. Let me know if this PR (and the linked one) doesn’t fit the project’s goals, and I’ll close them or adjust as you wish if needed. Looking forward to hearing your thoughts! |
bigcat88
force-pushed
the
sync/backend/pr/6376
branch
from
7a31e76 to
d1b65be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that reflects the changes from this PR in the backend: comfyanonymous/ComfyUI#6376
Why this is needed is described in the backend PR.
┆Issue is synchronized with this Notion page by Unito