Fix: Return None for Over-Segmented IPv6 Addresses #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the current implementation of the
Ipv6Address.fromString
method. Previously, an IPv6 address with too many segments would cause an exception instead of returningNone
. This PR introduces a fix to ensure that over-segmented IPv6 addresses correctly returnNone
, aligning with the expected behavior of the method.Changes:
numCondensedZeroes
, which indicates over-segmentation.Examples:
1:1:1:1:1:1:2:1:3
, theIpv6Address.fromString
method would throw ajava.lang.ArrayIndexOutOfBoundsException: Index 16 out of bounds for length 16
.None
, indicating an invalid IPv6 address, as expected.::1:1:1:1:1:1:2:1:3
, theIpv6Address.fromString
method would throw ajava.lang.ArrayIndexOutOfBoundsException: Index -2 out of bounds for length 16
.None
, indicating an invalid IPv6 address, as expected.