-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for the collection of Component Firmware Version and other details #82
Adding support for the collection of Component Firmware Version and other details #82
Conversation
Hi @jenniferKaiser21, has the additional scrapes for the firmware versions caused a drastic increase in total scrape durations? |
@derrick-dacosta , it depends on how many firmware components are collected, but it can increase the scrape time by a fair amount. Here are a few examples, and I can provide you server hostnames privately if you're interested: Time test with and without firmware gatheringServer 1:iLO 5 Server 2:iLO 5 Server 3:iLO 5 Server 4:iLO 5 Server 5:iLO 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to update the CHANGELOG
but after that LGTM! Then we should add a new arg flag to exclude certain firmware Inventory scrapes.
@derrick-dacosta @ibrahimkk-moideen , I've added the firmware.modules-exclude flag, updated the README, and the CHANGELOG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary of Enhancements
This PR further enhances the metrics gathering of all currently supported server models for collection of vital Firmware Inventory Component details, such as firmware version. This enhancement considers the wide variety of configurations, including iLO version and physical variances, accounting for the multiple endpoint possibilities for metrics collection.
Testing results
Tested locally against 47 servers with different hardware configuration, and iLO versions. Notably, tested against Cisco servers that do not have the firmware inventory.
iLO Versions Tested:
⁃ {firmwareVersion="4.1(3e)"}
⁃ {firmwareVersion="4.0(2m)"}
⁃ {firmwareVersion="4.2(3b)"}
⁃ {firmwareVersion="4.2(2f)"}
⁃ {firmwareVersion="4.1(3g)"}
⁃ {firmwareVersion="4.1(2a)"}
⁃ {firmwareVersion="4.0(4d)"}
⁃ {firmwareVersion="4.3(2.230270)"}
⁃ {firmwareVersion="4.2(3b)"}
⁃ {firmwareVersion="4.2(2a)"}
⁃ {firmwareVersion="4.1(2a)"}
⁃ {firmwareVersion="4.1(1f)"}
⁃ {firmwareVersion="4.0(4h)"}
⁃ {firmwareVersion="4.0(1a)"}
⁃ {firmwareVersion="3.1(3a)"}
⁃ {firmwareVersion="4.2(3d)"}
⁃ {firmwareVersion="4.2(3b)"}
⁃ {firmwareVersion="4.2(1g)"}
⁃ {firmwareVersion="4.2(1f)"}
⁃ {firmwareVersion="iLO 6 v1.59"}
⁃ {firmwareVersion="iLO 5 v2.95"}
⁃ {firmwareVersion="iLO 5 v2.44"}
⁃ {firmwareVersion="iLO 5 v2.71"}
⁃ {firmwareVersion="iLO 4 v2.80"}
⁃ {firmwareVersion="iLO 5 v2.91"}
⁃ {firmwareVersion="iLO 5 v2.98"}
⁃ {firmwareVersion="iLO 5 v2.65"}
⁃ {firmwareVersion="iLO 5 v2.98"}
⁃ {firmwareVersion="iLO 5 v2.44"}
⁃ {firmwareVersion="iLO 5 v3.03"}
⁃ {firmwareVersion="iLO 4 v2.82"}
⁃ {firmwareVersion="iLO 5 v2.72"}
⁃ {firmwareVersion="iLO 5 v2.55"}
⁃ {firmwareVersion="iLO 4 v2.61"}
⁃ {firmwareVersion="iLO 4 v2.79"}
⁃ {firmwareVersion="iLO 5 v2.55"}
⁃ {firmwareVersion="iLO 5 v2.42"}
⁃ {firmwareVersion="iLO 5 v1.37"}
⁃ {firmwareVersion="iLO 4 v2.82"}
⁃ {firmwareVersion="iLO 4 v2.61"}
⁃ {firmwareVersion="iLO 5 v2.78"}
⁃ {firmwareVersion="iLO 5 v2.65"}
Hardware Tested:
⁃ XL420
⁃ Dell PowerEdge R7615
⁃ Synergy 480
⁃ HP DL360
⁃ HP DL325
⁃ HP DL380
⁃ HP DL20
⁃ HP DL365
⁃ Cisco c220
⁃ Cisco c225
⁃ s3260m5
⁃ s3260m4
Below are the truncated results:
iLO 5 Examples:
firmwareVersion="iLO 5 v3.03"
firmwareVersion="iLO 5 v2.65"
firmwareVersion="iLO 5 v2.78"
iLO 4 Examples
firmwareVersion="iLO 4 v2.61
Cisco servers (testing to ensure it doesn’t break the scrape)