Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to storage controller and memory metrics #80

Merged
merged 3 commits into from
Jun 20, 2024
Merged

updates to storage controller and memory metrics #80

merged 3 commits into from
Jun 20, 2024

Conversation

ibrahimkk-moideen
Copy link
Collaborator

This PR addresses issue #79.

@ibrahimkk-moideen ibrahimkk-moideen linked an issue Jun 5, 2024 that may be closed by this pull request
Update Memory and Storage controller Metrics #79
Closed
@ibrahimkk-moideen ibrahimkk-moideen requested review from derrick-dacosta and removed request for derrick-dacosta June 6, 2024 14:00
derrick-dacosta
derrick-dacosta previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@derrick-dacosta derrick-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think you need to just update the CHANGELOG

@ibrahimkk-moideen
Copy link
Collaborator Author

Added below in commit a081449

  • Virtual drives status added to "redfish_logical_drive_status"
  • "redfish_memory_status" metric updated to include decimal values as seen on some Dell models.

@ibrahimkk-moideen ibrahimkk-moideen merged commit 3e60fc2 into main Jun 20, 2024
3 checks passed
@ibrahimkk-moideen ibrahimkk-moideen deleted the cpu_storcontroller_updates branch July 1, 2024 14:06
@ibrahimkk-moideen ibrahimkk-moideen mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrick-dacosta derrick-dacosta derrick-dacosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Memory and Storage controller Metrics
2 participants
@ibrahimkk-moideen @derrick-dacosta