-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add Respawn Details Into Briefing #234
[Feature] Add Respawn Details Into Briefing #234
Conversation
Addresses Issue #202 |
May make another PR for a similar thing, but with medical settings. |
_briefing = ""; | ||
_side = side player; | ||
|
||
_respawnModeTimedText = str RESPAWN_MODE_TIMED; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lord forgive me.
#endif | ||
#ifdef RESPAWN_PLAYER_TICKETS_CIVILIAN | ||
_individualTickets = RESPAWN_PLAYER_TICKETS_CIVILIAN; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for I have sinned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see a better way to do this tbh, so good approach. Few minor things - fix yourself or I will in a year or two. tyvm
// CA - Respawn briefing section | ||
// ==================================================================================== | ||
|
||
_briefing = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use private
keyword pls
components/briefing/macros.hpp
Outdated
#include "../../macros.hpp" | ||
|
||
#define RESPAWN_MODE_NAME_TIMED "Timed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer to have these in respawn_macros.hpp
so they're in the same place as the things they refer to.
Skill issue.
3c6042b
to
43801db
Compare
Pull Request Description
When merged this pull request will:
Release Notes
Framework
part of the briefing, there is a newCurrent Respawn Settings
entry."Timed Waves, with Tickets"
)IMPORTANT
[Descriptor] - Add|Fix|Improve|Change|Make|Remove {changes}
.