Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project invoice terms #3672

Merged
merged 65 commits into from
Jul 8, 2024
Merged

Add project invoice terms #3672

merged 65 commits into from
Jul 8, 2024

Conversation

AbhishekNegi25
Copy link
Contributor

@AbhishekNegi25 AbhishekNegi25 commented Jun 28, 2024 •
edited
Loading

Targets #3666

Description of the changes

  • Added a table project_invoice_terms in database to keep record of scheduled invoices in project level.
  • Added the Scheduled invoices tab in Invoice page to show the list of all the scheduled invoices.
  • Added new field in project update form to add invoice terms on a project.
  • Added tooltips on Billing level and google chat webhook url fields describing the purpose of the field (Project update form).
  • Renamed Project type to Billing cycle (Project update form).
  • Added a link to client financial detail tab under Upload Contract File (Project update form).

Breakdown & Estimates

Expected Time Range:

Actual Time:

Feedback Cycle

Cycle Count: 0

Checklist:

  • The PR title follows this syntax: <#IssueID> <PR Title>
  • I have linked the issue id in the PR description.
  • I have performed a self-review of my own code.
  • I have added comments on my code changes where required.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

Coverage report for commit: 9817e1b
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 82.1%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.7%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 15.4%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 2.96% | Methods: 5.35%
FilesLinesMethodsBranches
app/Casts
   Decrypted.php--100.00%
app/Console/Commands
   CheckCommand.php--100.00%
   FakeProdDataCommand.php2.00%11.11%100.00%
   Setup.php--100.00%
app/Console
   Kernel.php10.53%50.00%100.00%
app/Exceptions
   Handler.php--100.00%
app/Helpers
   ContentHelper.php--100.00%
   DateHelper.php--100.00%
   DecimalToWordsHelper.php--100.00%
   FileHelper.php--100.00%
app/Http/Controllers/Auth
   ForgotPasswordController.php--100.00%
   LoginController.php--100.00%
   RegisterController.php--100.00%
   ResetPasswordController.php--100.00%
app/Http/Controllers/CRM
   CRMController.php--100.00%
app/Http/Controllers
   ClientController.php--100.00%
   CommentController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php26.47%50.00%100.00%
   ProjectController.php--100.00%
   ProjectStageController.php--100.00%
   UserBookController.php--100.00%
   UserController.php--100.00%
app/Http/Controllers/Finance
   InvoiceController.php--100.00%
   PaymentController.php--100.00%
   ReportsController.php--100.00%
app/Http/Controllers/HR/Applications
   VolunteerApplicationController.php--100.00%
app/Http/Controllers/HR/Volunteers
   CampaignsController.php--100.00%
   ReportsController.php--100.00%
   VolunteerOpportunityController.php--100.00%
app/Http/Controllers/KnowledgeCafe
   KnowledgeCafeController.php--100.00%
   WeeklyDoseController.php--100.00%
app/Http/Controllers/KnowledgeCafe/Library
   BookCategoryController.php--100.00%
   BookCommentController.php--100.00%
   BookController.php--100.00%
app/Http/Controllers/Settings
   BankDetailController.php--100.00%
   ConfigurationController.php--100.00%
   HRController.php--100.00%
   NDAAgreementController.php--100.00%
   PermissionController.php--100.00%
   SettingController.php--100.00%
app/Http
   Kernel.php100.00%100.00%100.00%
app/Http/Middleware
   EncryptCookies.php100.00%100.00%100.00%
   RedirectIfAuthenticated.php--100.00%
   TrimStrings.php100.00%100.00%100.00%
   TrustProxies.php100.00%100.00%100.00%
   VerifyCsrfToken.php100.00%100.00%100.00%
app/Http/Requests
   ClientRequest.php--100.00%
   ProjectRequest.php--100.00%
   ProjectStageRequest.php--100.00%
app/Http/Requests/Finance
   InvoiceRequest.php--100.00%
   PaymentRequest.php--100.00%
app/Http/Requests/KnowledgeCafe/Library
   BookCategoryRequest.php--100.00%
   BookRequest.php--100.00%
app/Http/Requests/KnowledgeCafe
   WeeklyDoseRequest.php--100.00%
app/Http/Requests/Setting
   SettingRequest.php--100.00%
   UpdateRolePermissionsRequest.php--100.00%
   UpdateUserRolesRequest.php--100.00%
app/Http/View/Composers
   CodeTrekApplicantsComposer.php100.00%100.00%100.00%
app/Imports
   ApplicationImport.php--100.00%
app/Listeners
   RemoveUserFromWebsite.php--100.00%
app/Mail
   DailyEffortSummary.php--100.00%
   ErrorReport.php--100.00%
   sendEmail.php--100.00%
app/Models
   BankDetails.php100.00%100.00%100.00%
   Category.php--100.00%
   Client.php--100.00%
   ClientCrmDetails.php--100.00%
   Comment.php--100.00%
   Country.php100.00%100.00%100.00%
   Project.php--100.00%
   ProjectStage.php--100.00%
   ProjectStageBilling.php--100.00%
   Resource.php--100.00%
   Setting.php--100.00%
   SkillSet.php100.00%100.00%100.00%
   Tag.php--100.00%
app/Models/Finance
   Invoice.php--100.00%
   Payment.php--100.00%
app/Models/Finance/PaymentModes
   Cash.php--100.00%
   Cheque.php--100.00%
   WireTransfer.php--100.00%
app/Models/KnowledgeCafe/Library
   Book.php13.79%13.64%100.00%
   BookAMonth.php--100.00%
   BookCategory.php--100.00%
app/Models/KnowledgeCafe
   WeeklyDose.php100.00%100.00%100.00%
app/Notifications
   ReviewNDA.php--100.00%
app/Observers
   UserObserver.php100.00%100.00%100.00%
app/Policies
   ClientPolicy.php--100.00%
   ProjectPolicy.php--100.00%
   SettingPolicy.php--100.00%
   UserPolicy.php--100.00%
app/Policies/Finance
   InvoicePolicy.php--100.00%
   ReportPolicy.php--100.00%
app/Policies/Infrastructure
   BillingsPolicy.php--100.00%
app/Policies/KnowledgeCafe/Library
   BookCategoryPolicy.php--100.00%
   BookPolicy.php--100.00%
app/Policies/KnowledgeCafe
   WeeklyDosePolicy.php--100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   ApplicantsComposerServiceProvider.php100.00%100.00%100.00%
   AuthServiceProvider.php100.00%100.00%100.00%
   BroadcastServiceProvider.php--100.00%
   DatabaseServiceProvider.php100.00%100.00%100.00%
   EventServiceProvider.php100.00%100.00%100.00%
   RouteServiceProvider.php100.00%100.00%100.00%
app/Rules
   TeamMemberDesignationRule.php--100.00%
   TeamMemberRule.php--100.00%
app/Services
   BookServices.php--100.00%
   CRMServices.php--100.00%
   CalendarEventService.php--100.00%
   EmployeeService.php--100.00%
   GSuiteUserService.php--100.00%
   SettingService.php--100.00%
   WebsiteUserService.php--100.00%
app/Traits
   Encryptable.php--100.00%
   Filters.php--100.00%
   HasTags.php--100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@cypress Cypress
Copy link

cypress bot commented Jun 28, 2024 •
edited
Loading

Passing run #8705 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 9817e1b into aff8928...
Project: Employee portal Commit: 90d2d82de9 ℹ️
Status: Passed Duration: 00:28 💡
Started: Jul 5, 2024 8:30 AM Ended: Jul 5, 2024 8:30 AM

Review all test suite changes for PR #3672 ↗︎

@AbhishekNegi25 AbhishekNegi25 changed the title project invoice terms Add project invoice terms Jun 28, 2024
@AbhishekNegi25 AbhishekNegi25 self-assigned this Jun 28, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 3.37%. Comparing base (4d9dc56) to head (c5f7876).
Report is 20 commits behind head on master.

❗ Current head c5f7876 differs from pull request most recent head 7743074

Please upload reports for the commit 7743074 to get more accurate results.

Files Patch % Lines
app/Console/Kernel.php 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             master   #3672      +/-   ##
===========================================
+ Coverage      3.10%   3.37%   +0.27%     
- Complexity      594     595       +1     
===========================================
  Files           105     106       +1     
  Lines          2129    2133       +4     
===========================================
+ Hits             66      72       +6     
+ Misses         2063    2061       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@P4NK4J P4NK4J merged commit b59f1b2 into master Jul 8, 2024
6 checks passed
@P4NK4J P4NK4J deleted the feature/project-invoice-terms branch July 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P4NK4J P4NK4J P4NK4J approved these changes

Assignees

@AbhishekNegi25 AbhishekNegi25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhishekNegi25 @P4NK4J