Skip to content

refactor(proxy): Move functions, clean spacing/brackets, return values #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Contributor

A style update and minimal refactoring:

  • Consolidate all functions together
  • Consistent brackets/brace/spacing usage
  • Declare return values

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 261 has to be
$expVer = '%COOLWSD_VERSION_HASH%';
for sed to be able to change it to the current version hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants