browser: jsbuilder: replace button label for span element #10986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessibility request to remove "label for" elements for button Change-Id: Ief83bb73f6befbe39097de3e6aa550d58fd04de5 Signed-off-by: Henry Castro <[email protected]>
eszkadev
reviewed
Jan 22, 2025
| label.textContent = builder._cleanText(data.text); | ||
| builder._stressAccessKey(label, button.accessKey); | ||
| controls['label'] = label; | ||
| var span = L.DomUtil.create('span', 'ui-content unolabel', button); |
There was a problem hiding this comment.
Are we sure we want to remove native "label" type?
It provides automatic information for text-to-speach software what to read and which input field it labels
There was a problem hiding this comment.
I see it's not for button element: https://www.w3schools.com/tags/tag_label.asp
There was a problem hiding this comment.
but don't we need to add 'labelled-by' or 'labelFor' then?
There was a problem hiding this comment.
It does not specify the attribute change in the task description. Please ask Lilly for more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility request to remove "label for" elements for button
Change-Id: Ief83bb73f6befbe39097de3e6aa550d58fd04de5
Signed-off-by: Henry Castro [email protected]