Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust comment styling for extended cells to ensure consistent appearance #10771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

banobepascal
Copy link

@banobepascal banobepascal commented Dec 19, 2024

Change-Id: Ia3b6ac17ad1f4677e61d9128806bac90a819bfb3

Summary

This fix addresses an issue where comments in cells appeared misaligned or visually inconsistent when the cell was extended

Visual Representation

Screenshot from 2024-12-25 11-43-11
Screenshot from 2024-12-25 11-43-37

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@banobepascal banobepascal force-pushed the private/banobepascal/cell-comment-design branch from 3aff15e to 2a8756f Compare December 19, 2024 12:31
@banobepascal
Copy link
Author

banobepascal commented Dec 20, 2024

@pedropintosilva @eszkadev please review

Copy link
Contributor

@eszkadev eszkadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it requires fix for RTL sheet layout->RTL (not confuse with RTL UI <URL>&lang=ar)

rtl

Also it is now not aligned to the cell border (has some gap), is it intended?

@banobepascal banobepascal force-pushed the private/banobepascal/cell-comment-design branch from 2a8756f to 788afea Compare December 25, 2024 08:40
@banobepascal
Copy link
Author

I think it requires fix for RTL sheet layout->RTL (not confuse with RTL UI <URL>&lang=ar)

rtl

Also it is now not aligned to the cell border (has some gap), is it intended?

Removed gap and also fixed RTL

Screenshot from 2024-12-25 11-43-37
Screenshot from 2024-12-25 11-43-11

@banobepascal
Copy link
Author

@eszkadev please review the changes

@eszkadev
Copy link
Contributor

I can confirm now it is better and RTL works.
I found that with lower zoom we still have the same size of triangle as with large zoom.
So with 50% it looks bigger than a cell and with 200% small:
zoom

Also in RTL there is 1px gap on the left edge if we want to be pixel-perfect.

…ance

Signed-off-by: Banobe Pascal <[email protected]>
Change-Id: Ia5d5fe9f370fc4d2153d97c229860b95552eebea
@banobepascal banobepascal force-pushed the private/banobepascal/cell-comment-design branch from 788afea to 5ff8df5 Compare December 26, 2024 14:27
@banobepascal
Copy link
Author

I can confirm now it is better and RTL works. I found that with lower zoom we still have the same size of triangle as with large zoom. So with 50% it looks bigger than a cell and with 200% small: zoom

Also in RTL there is 1px gap on the left edge if we want to be pixel-perfect.

The triangle is now adjusting according to the zoom level
Screenshot from 2024-12-26 17-24-53
Screenshot from 2024-12-26 17-24-23

The reason for the RTL margin 1px is because of the column borders are not straight with the top bar so if the column or row borders are adjusted this creates a misalignment.
Screenshot from 2024-12-26 17-22-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Design bits - New comment in cells look odd when the cell is extended
2 participants