Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore: ✏️ Fix Entity By ChatMember's Name Domain Rule #208

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Ignore: ✏️ Fix Entity By ChatMember's Name Domain Rule #208

merged 7 commits into from
Nov 28, 2024

Conversation

psychology50
Copy link
Member

작업 이유

  • The designer requested aligning chat members' names with users' names for consistency.

작업 사항

  • Removed the name field from the chat_member table.
  • Implemented a database join with the user table to fetch names when retrieving chat member data.

리뷰어가 중점적으로 확인해야 하는 부분

  • none

발견한 이슈

  • none

@psychology50 psychology50 added the enhancement New feature or request label Nov 28, 2024
@psychology50 psychology50 self-assigned this Nov 28, 2024
@psychology50 psychology50 merged commit fc333f5 into dev Nov 28, 2024
1 check passed
@psychology50 psychology50 deleted the fix/PW-647-chat-member-name branch November 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@psychology50 psychology50

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psychology50