Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket: ✏️ Heartbeat negotiation interceptor #183

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

psychology50
Copy link
Member

작업 이유

  • Implement negotiation interceptor by STOMP
  • Currently, there is an issue where the server follows the heartbeat value set by the client.

작업 사항

  • When using external message broker, the negotiation process is handled by the broker, not by Spring
  • But, the RabbitMQ STOMP Plugin doesn't support configuring server-side heartbeat
  • So, I implemented an interceptor logic where the heartbeat negotiation is handled by Spring and then passed to RabbitMQ, which consistently follows the client's heartbeat setting.

리뷰어가 중점적으로 확인해야 하는 부분

  • I've written all the details on my blog. Please refer to the link for more informations

발견한 이슈

  • none

@psychology50 psychology50 added the enhancement New feature or request label Oct 25, 2024
@psychology50 psychology50 self-assigned this Oct 25, 2024
@psychology50 psychology50 merged commit 7f74e8c into dev Oct 25, 2024
1 check passed
@psychology50 psychology50 deleted the fix/socket-heart-beat branch October 25, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant